Translates: title, header and breadcrumbs#10
Open
mblarsen wants to merge 3 commits intomiguelbalparda:masterfrom
Open
Translates: title, header and breadcrumbs#10mblarsen wants to merge 3 commits intomiguelbalparda:masterfrom
mblarsen wants to merge 3 commits intomiguelbalparda:masterfrom
Conversation
Converted file types to UNIX from DOS. (standard)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements translation of title, header and breadcrumbs for pages.
I moved the module getter into Helper/Data in order to reuse the code for all classes in the extension.
Also I changed the filetype to UNIX to DOS for some of the files. It was mixed.
This PR was started from #8