Skip to content

fix: improve offline check task alerting logic and status updates#63

Open
hauju wants to merge 1 commit intomighty840:mainfrom
hauju:fix/status-view
Open

fix: improve offline check task alerting logic and status updates#63
hauju wants to merge 1 commit intomighty840:mainfrom
hauju:fix/status-view

Conversation

@hauju
Copy link
Copy Markdown

@hauju hauju commented Apr 2, 2026

Summary

  • Decouple device status updates from webhook alerting — offline check task now always marks stale devices as "offline" even when ALERT_WEBHOOK_URL is not configured
  • Reduce redundant iteration by collecting stale devices once and reusing for both status update and alert payload construction
  • Improve startup logging to clearly indicate whether webhook alerting is active

Test plan

  • Verify devices transition to "offline" status without ALERT_WEBHOOK_URL set
  • Verify webhook alerts still fire when ALERT_WEBHOOK_URL is configured
  • Run cargo test -p ferrite-server

🤖 Generated with Claude Code

@mighty840
Copy link
Copy Markdown
Owner

Looks like this works. Can you verify and close the open tasks so we can merge?

@mighty840 mighty840 self-requested a review April 8, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants