feat(AGGrid): add dynamic row and container heights based on size variant #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying ui with
|
| Latest commit: |
96826d6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f2161e04.ui-6d0.pages.dev |
| Branch Preview URL: | https://feature-ag-grid-height-updte.ui-6d0.pages.dev |
…iant - Add rowHeight and headerHeight props to AgGridReact based on size - Add size-based default container heights (xs=280, sm=320, md=400, lg=480, xl=560) - Height prop now optional - defaults to size-appropriate value when not provided - Fix size control in Storybook to properly change row heights (CSS classes alone don't work) - Update sizeToRowHeight mapping to include containerHeight for each size variant Size mapping: - xs: rowHeight=28px, headerHeight=28px, containerHeight=280px - sm: rowHeight=32px, headerHeight=32px, containerHeight=320px - md: rowHeight=40px, headerHeight=40px, containerHeight=400px (default) - lg: rowHeight=48px, headerHeight=48px, containerHeight=480px - xl: rowHeight=56px, headerHeight=56px, containerHeight=560px The height prop can still be explicitly provided to override the default.
garrity-miepub
force-pushed
the
feature/ag-grid-height-updte
branch
from
269e1e7 to
96826d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Size mapping:
The height prop can still be explicitly provided to override the default.
ag-grid-height.mov