fix(lint): replace bare alert() with window.alert() across stories #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying ui with
|
| Latest commit: |
f7e6c9a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0e9ed42e.ui-6d0.pages.dev |
| Branch Preview URL: | https://bugfix-lint-errors.ui-6d0.pages.dev |
Fixed 47 react-hooks/rules-of-hooks violations in 22 story files by extracting inline useState/useEffect from render functions into named wrapper components. Reduced total ESLint errors from 194 to 144.
garrity-miepub
force-pushed
the
bugfix/lint-errors
branch
from
a34b8cc to
3f4e71c
Compare
…config - Escaped apostrophes and quotes in JSX text content: - AddContactModal: "Add Field" quotes - AuthDialog: We've, Don't, we'll apostrophes - InvoicePaymentPage: you're, doesn't apostrophes - OnboardingWizard: You're apostrophes - Added missing DOM globals to eslint.config.js: - HTMLFormElement, HTMLSelectElement, HTMLAnchorElement - SVGSVGElement, Node - confirm (browser API) - google (Google Maps API) Reduces total errors from 111 to 83 (-28 errors)
- HelpSupportPanel: Quick Links section now uses buttons - OnboardingWizard: Logo section uses span instead of anchor - OrderLookupForm: Contact Support uses button - ProductVersion.stories: Footer links use buttons - StripeBadge.stories: Privacy Policy uses button Reduces total errors from 83 to 73 (-10 errors)
- Address.tsx: Convert AddressInlineProps and AddressCompactProps from empty interfaces to type aliases - ErrorPage.tsx: Convert NotFoundPageProps from empty interface to type alias - WebChartReportViewer.tsx: Wrap case block const declaration in braces Reduces total errors from 73 to 69 (-4 errors)
- Added role='button', tabIndex, and onKeyDown handlers to interactive divs - AuthDialog: backdrop supports Escape key - CheckrIntegration: modal backdrop is keyboard accessible - EmployerContactCard: contact items support Enter key - EmployerList: employer items support Enter key - LanguageSelector: options support Enter key - NotificationCenter: notification items support Enter key - ProviderOverview: activity items and stat cards support Enter key - ScheduleCalendar: hour slots and appointments support Enter key - WebChartReportViewer: offcanvas backdrop is keyboard accessible Reduces total errors from 69 to 49 (-20 errors)
- Added eslint-disable comments for autoFocus in modals and dropdowns where focusing the input improves UX - Added eslint-disable for dialog backdrop click handler - InviteUserModal, ProviderSearchFilters, ProviderSelector, AuthDialog Reduces total errors from 49 to 45 (-4 errors)
- Fix conditional useId() calls in AddressForm.tsx and ProviderSearchFilters.tsx - Always call useId() unconditionally first, then use value conditionally - Add eslint-disable for intentional exhaustive-deps in Google Places effect
- Update Button tests to match actual component behavior
- Button doesn't set aria-busy when not loading (was undefined, not 'false')
- Use querySelector for SVG with aria-hidden instead of getByRole('img')
- Apply Prettier formatting to all source files
- Upgrade all CI jobs from Node.js 18 to Node.js 20 (required by Storybook) - Add missing Storybook build step to visual-tests job - Memory allocation already set for Storybook builds
- Use platform-agnostic snapshot names (remove -chromium-darwin suffix) - Configure snapshotPathTemplate in playwright.config.ts - Add 5% pixel diff tolerance for cross-platform rendering differences - Increase NODE_OPTIONS memory from 4096MB to 8192MB for Storybook builds
There was a problem hiding this comment.
Pull request overview
This pull request fixes ESLint errors by replacing bare alert() calls with window.alert() across story files. However, the PR contains significantly more changes than described, including extensive Prettier formatting changes, refactoring of story components, and CI/configuration updates.
Changes:
- Replaced
alert()withwindow.alert()in 14 story files to fix ESLintno-undeferrors - Applied Prettier formatting changes across 100+ files (Tailwind class reordering, line breaks, etc.)
- Refactored inline story render functions into separate wrapper components
- Updated CI configuration (Node 18 → 20, memory limits, accessibility test handling)
- Added ESLint globals and Playwright snapshot configuration
Reviewed changes
Copilot reviewed 131 out of 151 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Story files (14) | Fixed alert() → window.alert() as described |
| Component files (50+) | Prettier formatting only (Tailwind class reordering, line breaks) |
| Test files | Minor test assertion updates |
| Configuration files | CI/Node version updates, ESLint globals, Playwright config |
| All other files | Formatting and minor refactoring improvements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed 45 ESLint 'alert is not defined' (no-undef) errors by prefixing all alert() calls with window. in the following story files:
Reduces total lint errors from 239 to 194.