Skip to content

fix(RecordButton): Fix temporal dead zone error breaking Dashboard #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
garrity-miepub wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(RecordButton): Fix temporal dead zone error breaking Dashboard #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions src/components/RecordButton/RecordButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,23 @@ function RecordButton({
};
}, []);

const stopRecording = React.useCallback(() => {
if (timerRef.current) {
clearInterval(timerRef.current);
}

if (
mediaRecorderRef.current &&
mediaRecorderRef.current.state !== 'inactive'
) {
mediaRecorderRef.current.stop();
}

if (streamRef.current) {
streamRef.current.getTracks().forEach((track) => track.stop());
}
}, []);
Comment on lines +264 to +279
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding/expanding a Playwright Storybook render/visual test that covers the Dashboard story (or a RecordButton story) to prevent regressions where RecordButton fails to render due to hook callback ordering/initialization errors (this bug was only caught at runtime in Storybook).

Copilot uses AI. Check for mistakes.

const startRecording = React.useCallback(async () => {
if (disabled || isRecording || isProcessing) return;

Expand Down Expand Up @@ -327,23 +344,6 @@ function RecordButton({
stopRecording,
]);

const stopRecording = React.useCallback(() => {
if (timerRef.current) {
clearInterval(timerRef.current);
}

if (
mediaRecorderRef.current &&
mediaRecorderRef.current.state !== 'inactive'
) {
mediaRecorderRef.current.stop();
}

if (streamRef.current) {
streamRef.current.getTracks().forEach((track) => track.stop());
}
}, []);

const handleClick = React.useCallback(() => {
if (isRecording) {
stopRecording();
Expand Down
Loading