Skip to content

chore: move tex init into static function #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hkonsti merged 2 commits into from
May 9, 2025
Merged

chore: move tex init into static function #359

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97bfd4a
chore: move init into static function
hkonsti Apr 20, 2025
a6c8b39
fix: lint
hkonsti Apr 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 24 additions & 11 deletions packages/2d/src/lib/components/Latex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import type {SignalValue, SimpleSignal} from '@revideo/core';
import {DependencyContext, useLogger} from '@revideo/core';
import type {LiteAdaptor} from 'mathjax-full/js/adaptors/liteAdaptor';
import {liteAdaptor} from 'mathjax-full/js/adaptors/liteAdaptor';
import type {MathDocument} from 'mathjax-full/js/core/MathDocument';
import {RegisterHTMLHandler} from 'mathjax-full/js/handlers/html';
import {TeX} from 'mathjax-full/js/input/tex';
import {AllPackages} from 'mathjax-full/js/input/tex/AllPackages';
Expand All @@ -11,16 +13,6 @@ import {initial, signal} from '../decorators';
import type {ImgProps} from './Img';
import {Img} from './Img';

const Adaptor = liteAdaptor();
RegisterHTMLHandler(Adaptor);

const JaxDocument = mathjax.document('', {
// eslint-disable-next-line @typescript-eslint/naming-convention
InputJax: new TeX({packages: AllPackages}),
// eslint-disable-next-line @typescript-eslint/naming-convention
OutputJax: new SVG({fontCache: 'local'}),
});

export interface LatexProps extends ImgProps {
tex?: SignalValue<string>;
renderProps?: SignalValue<OptionList>;
Expand All @@ -46,6 +38,24 @@ export interface LatexProps extends ImgProps {
*/
export class Latex extends Img {
private static svgContentsPool: Record<string, string> = {};
private static mathJaxInitialized = false;
private static adaptor: LiteAdaptor;
private static jaxDocument: MathDocument<unknown, unknown, unknown>;

private static initializeMathJax() {
if (this.mathJaxInitialized) {
return;
}
this.adaptor = liteAdaptor();
RegisterHTMLHandler(this.adaptor);
this.jaxDocument = mathjax.document('', {
// eslint-disable-next-line @typescript-eslint/naming-convention
InputJax: new TeX({packages: AllPackages}),
// eslint-disable-next-line @typescript-eslint/naming-convention
OutputJax: new SVG({fontCache: 'local'}),
});
this.mathJaxInitialized = true;
}

private readonly imageElement = document.createElement('img');

Expand All @@ -58,6 +68,7 @@ export class Latex extends Img {

public constructor(props: LatexProps) {
super({...props, src: null});
Latex.initializeMathJax();
}

protected override image(): HTMLImageElement {
Expand All @@ -79,7 +90,9 @@ export class Latex extends Img {

// Convert to TeX, look for any errors
const tex = this.tex();
const svg = Adaptor.innerHTML(JaxDocument.convert(tex, this.options()));
const svg = Latex.adaptor.innerHTML(
Latex.jaxDocument.convert(tex, this.options()) as any,
);
if (svg.includes('data-mjx-error')) {
const errors = svg.match(/data-mjx-error="(.*?)"/);
if (errors && errors.length > 0) {
Expand Down