Skip to content

feat(player-react): let user modify onClick behavior #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justusmattern27 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(player-react): let user modify onClick behavior #313

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
086e50d
feat(player-react): let user modify onClick behavior
justusmattern27 Oct 3, 2024
35e8ed7
style: prettier
justusmattern27 Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/player-react/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ interface PlayerProps {
onTimeUpdate?: (currentTime: number) => void;
onPlayerReady?: (player: CorePlayer) => void;
onPlayerResize?: (rect: DOMRectReadOnly) => void;
onClick?: () => void;
}

export function Player({
Expand All @@ -65,6 +66,7 @@ export function Player({
onTimeUpdate = () => {},
onPlayerReady = () => {},
onPlayerResize = () => {},
onClick,
}: PlayerProps) {
const [playingState, setPlaying] = useState(playing);
const [isMouseOver, setIsMouseOver] = useState(false);
Expand All @@ -77,7 +79,8 @@ export function Player({
const wrapperRef = useRef<HTMLDivElement | null>(null);
const lastRect = useRef<DOMRectReadOnly | null>(null);

const onClickHandler = controls ? () => setPlaying(prev => !prev) : undefined;
const onClickHandler =
onClick || (controls ? () => setPlaying(prev => !prev) : undefined);

/**
* Sync the playing prop with the player's own state when it changes.
Expand Down