Skip to content

Conversation

@jsidorenko
Copy link
Contributor

Overview

find_effects method was returning only the last found effect ignoring the others.
This leads to transactions with multiple contract calls stored in one intent to fail.

Additionally, the new minter contract was added in toolkit-js tests replacing the old ut_contract.

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

Closes https://shielded.atlassian.net/browse/PM-20404

@jsidorenko jsidorenko requested a review from ozgb January 30, 2026 15:28
@jsidorenko jsidorenko requested a review from a team as a code owner January 30, 2026 15:28
@github-actions
Copy link
Contributor

kics-logo

KICS version: v2.1.16

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 94
LOW LOW 12
INFO INFO 83
TRACE TRACE 0
TOTAL TOTAL 189
Metric Values
Files scanned placeholder 28
Files parsed placeholder 28
Files failed to scan placeholder 0
Total executed queries placeholder 73
Queries failed to execute placeholder 0
Execution time placeholder 6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants