Skip to content

Conversation

@KrisF-Midnight
Copy link
Contributor

@KrisF-Midnight KrisF-Midnight commented Jan 28, 2026

https://shielded.atlassian.net/browse/SRE-1741

Overview

Add SBOM (Software Bill of Materials) generation and vulnerability scanning to CI/CD pipelines. This implements Phase 3 of the container security initiative, building on the Cosign image signing from Phase 1.

What this adds:

  • SBOM generation using Syft (SPDX-JSON format)
  • Vulnerability scanning with Grype (fails on high/critical CVEs)
  • SBOM attestation to images using Cosign keyless signing
  • Reusable workflow for consistent scanning across all pipelines

Key design decisions:

  • SBOM scans gate image publishing (atomic releases - all images pass or none publish)
  • External/fork PRs skip attestation (no OIDC token) but still generate SBOMs
  • Severity threshold set to high (fails on critical + high CVEs)
  • Architecture-specific images scanned (not multi-arch manifests)

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason: CI-only changes
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Local testing of sbom-scan.sh functions against test images

  • Verified Cosign attestation verification commands work locally

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other: CI/CD pipeline enhancement - no impact on node runtime or client
  • N/A

Links

@KrisF-Midnight KrisF-Midnight self-assigned this Jan 28, 2026
@KrisF-Midnight KrisF-Midnight requested a review from a team as a code owner January 28, 2026 15:36
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

kics-logo

KICS version: v2.1.16

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 94
LOW LOW 12
INFO INFO 83
TRACE TRACE 0
TOTAL TOTAL 189
Metric Values
Files scanned placeholder 29
Files parsed placeholder 29
Files failed to scan placeholder 0
Total executed queries placeholder 73
Queries failed to execute placeholder 0
Execution time placeholder 6

@KrisF-Midnight KrisF-Midnight force-pushed the SRE-1741/SBOM-and-scans branch from 0d30292 to 0b32a31 Compare January 29, 2026 15:33
@KrisF-Midnight KrisF-Midnight changed the title Sre 1741/SBOM and scans feat: SBOM + vulnerability scans Jan 29, 2026
@KrisF-Midnight KrisF-Midnight force-pushed the SRE-1741/SBOM-and-scans branch from bce560f to 734a824 Compare January 30, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants