Skip to content

fix(a11y): add keyboard accessibility in mgt-person line event story #3420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mnickii merged 2 commits into from
Mar 25, 2025
Merged

fix(a11y): add keyboard accessibility in mgt-person line event story #3420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ca3ee0
fix keyboard accessibility in mgt-person line event story
Mnickii Mar 24, 2025
42ce3b3
Merge branch 'main' into fix/a11y-3375
Mnickii Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 24 additions & 16 deletions packages/mgt-components/src/components/mgt-person/mgt-person.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,15 +939,17 @@ export class MgtPerson extends MgtTemplatedTaskComponent {
// Render the line1 template
const template = this.renderTemplate('line1', { person });
details.push(html`
<div class="line1" part="detail-line" @click=${() =>
this.handleLine1Clicked()} role="presentation" aria-label="${line1text}">${template}</div>
<div class="line1" part="detail-line" @click=${() => this.handleLine1Clicked()}
@keydown=${(e: KeyboardEvent) => e.key === 'Enter' && this.handleLine1Clicked()}
role="presentation" aria-label="${line1text}">${template}</div>
`);
} else {
// Render the line1 property value
if (line1text) {
details.push(html`
<div class="line1" part="detail-line" @click=${() =>
this.handleLine1Clicked()} role="presentation" aria-label="${line1text}">${line1text}</div>
<div class="line1" part="detail-line" @click=${() => this.handleLine1Clicked()}
@keydown=${(e: KeyboardEvent) => e.key === 'Enter' && this.handleLine1Clicked()}
role="presentation" aria-label="${line1text}">${line1text}</div>
`);
}
}
Expand All @@ -959,15 +961,17 @@ export class MgtPerson extends MgtTemplatedTaskComponent {
// Render the line2 template
const template = this.renderTemplate('line2', { person });
details.push(html`
<div class="line2" part="detail-line" @click=${() =>
this.handleLine2Clicked()} role="presentation" aria-label="${text}">${template}</div>
<div class="line2" part="detail-line" @click=${() => this.handleLine2Clicked()}
@keydown=${(e: KeyboardEvent) => e.key === 'Enter' && this.handleLine2Clicked()}
role="presentation" aria-label="${text}">${template}</div>
`);
} else {
// Render the line2 property value
if (text) {
details.push(html`
<div class="line2" part="detail-line" @click=${() =>
this.handleLine2Clicked()} role="presentation" aria-label="${text}">${text}</div>
<div class="line2" part="detail-line" @click=${() => this.handleLine2Clicked()}
@keydown=${(e: KeyboardEvent) => e.key === 'Enter' && this.handleLine2Clicked()}
role="presentation" aria-label="${text}">${text}</div>
`);
}
}
Expand All @@ -980,15 +984,17 @@ export class MgtPerson extends MgtTemplatedTaskComponent {
// Render the line3 template
const template = this.renderTemplate('line3', { person });
details.push(html`
<div class="line3" part="detail-line" @click=${() =>
this.handleLine3Clicked()} role="presentation" aria-label="${text}">${template}</div>
<div class="line3" part="detail-line" @click=${() => this.handleLine3Clicked()}
@keydown=${(e: KeyboardEvent) => e.key === 'Enter' && this.handleLine3Clicked()}
role="presentation" aria-label="${text}">${template}</div>
`);
} else {
// Render the line3 property value
if (text) {
details.push(html`
<div class="line3" part="detail-line" @click=${() =>
this.handleLine3Clicked()} role="presentation" aria-label="${text}">${text}</div>
<div class="line3" part="detail-line" @click=${() => this.handleLine3Clicked()}
@keydown=${(e: KeyboardEvent) => e.key === 'Enter' && this.handleLine3Clicked()}
role="presentation" aria-label="${text}">${text}</div>
`);
}
}
Expand All @@ -1001,15 +1007,17 @@ export class MgtPerson extends MgtTemplatedTaskComponent {
// Render the line4 template
const template = this.renderTemplate('line4', { person });
details.push(html`
<div class="line4" part="detail-line" @click=${() =>
this.handleLine4Clicked()} role="presentation" aria-label="${text}">${template}</div>
<div class="line4" part="detail-line" @click=${() => this.handleLine4Clicked()}
@keydown=${(e: KeyboardEvent) => e.key === 'Enter' && this.handleLine4Clicked()}
role="presentation" aria-label="${text}">${template}</div>
`);
} else {
// Render the line4 property value
if (text) {
details.push(html`
<div class="line4" part="detail-line" @click=${() =>
this.handleLine4Clicked()} role="presentation" aria-label="${text}">${text}</div>
<div class="line4" part="detail-line" @click=${() => this.handleLine4Clicked()}
@keydown=${(e: KeyboardEvent) => e.key === 'Enter' && this.handleLine4Clicked()}
role="presentation" aria-label="${text}">${text}</div>
`);
}
}
Expand Down
25 changes: 23 additions & 2 deletions stories/components/person/person.html.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,32 @@ export const person = () => html`
`;

export const events = () => html`
<!-- Check JS tab to see event listeners -->
<div style="margin-bottom: 10px">Click on each line</div>
<div class="example">
<mgt-person person-query="me" view="fourlines"></mgt-person>
<mgt-person person-query="me" view="fourlines">
<template data-type="line1">
<div tabindex="0">
Hello, my name is: {{person.displayName}}
</div>
</template>
<template data-type="line2">
<div tabindex="0">
✨ {{person.jobTitle}}
</div>
</template>
<template data-type="line3">
<div tabindex="0">
👀 {{person.department}}
</div>
</template>
<template data-type="line4">
<div tabindex="0">
📍{{person.mail}}
</div>
</template>
</mgt-person>
</div>

<div class="output">no line clicked</div>

<script>
Expand Down
Loading