Skip to content

Fix analyze e2e for invalid device#993

Merged
zhenchaoni merged 1 commit into
mainfrom
private/zhenni/fix_analyze_e2e
Jun 29, 2026
Merged

Fix analyze e2e for invalid device#993
zhenchaoni merged 1 commit into
mainfrom
private/zhenni/fix_analyze_e2e

Conversation

@zhenchaoni

Copy link
Copy Markdown
Member

Updated todo list

Fix outdated assertion in invalid device choice e2e test

Summary

test_invalid_device_choice_exits_two was asserting the substring "Invalid value for '--device'", but the --device flag exposes a short alias -d (via the shared device_option), so Click renders the error as Invalid value for '-d' / '--device'. The assertion no longer matched, causing the test to fail.

Change

  • Updated the assertion to the exact Click message: "Invalid value for '-d' / '--device'".

Notes

  • Unrelated to ep_options / device_options behavior — purely a test assertion drift.
  • The -d / --device pairing comes from the standard device_option decorator and is stable, so matching the exact string is safe.

Verification

uv run pytest tests/e2e/test_analyze_e2e.py -k invalid_device -m e2e
1 passed, 49 deselected

@zhenchaoni zhenchaoni requested a review from a team as a code owner June 29, 2026 07:09
@zhenchaoni zhenchaoni merged commit bb4fd3e into main Jun 29, 2026
9 checks passed
@zhenchaoni zhenchaoni deleted the private/zhenni/fix_analyze_e2e branch June 29, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants