Fix analyze e2e for invalid device#993
Merged
Merged
Conversation
KayMKM
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated todo list
Fix outdated assertion in invalid device choice e2e test
Summary
test_invalid_device_choice_exits_twowas asserting the substring"Invalid value for '--device'", but the--deviceflag exposes a short alias-d(via the shareddevice_option), so Click renders the error asInvalid value for '-d' / '--device'. The assertion no longer matched, causing the test to fail.Change
"Invalid value for '-d' / '--device'".Notes
ep_options/device_optionsbehavior — purely a test assertion drift.-d/--devicepairing comes from the standarddevice_optiondecorator and is stable, so matching the exact string is safe.Verification