-
Notifications
You must be signed in to change notification settings - Fork 142
Namespace refactoring #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Will resolve duplicate constants later.
|
@sotteson1 the CI build is failing saying the below were removed from the baseline, but I can't reproduce with a clean build locally. Local builds work fine with no differences. The baseline winmds on my machine from master and my branch don't have these APIs, and I can't find them defined anywhere in the SDK. In fact, we have another PR to add most of these manually, so it's not clear why the baseline used in the CI build has them. |
|
@mikebattista the same came up in #450 (comment), those constants/preprocessor-defines do not exist in the current SDK. Note that the last master commit failed. I cannot see the logs, but possibly @sotteson1 regenerated with a newer SDK in 24056ce (showing a similar size decrease as the comment linked above) making those constants reappear, clarifying the failure and the reason you see these errors in this PR too. |
|
Thanks. I just noticed master was failing as well as of 24056ce which I just merged into this branch. The |
That file is only used when debugging in VS. |
@MarijnS95 you might be right here but it might be a bug that the constant scraper is pulling things in from newer SDKs installed on the local machine, rather than the SDK that is expected to be used from the repo. Steve is looking into it. |
More namespace refactoring.
Need help resolving the below duplicate constants errors before merging.
Duplicate constants/enum names detected:
GUID_DEVINTERFACE_USBPRINT
Windows.Win32.Graphics.Printing.Apis
Windows.Win32.Graphics.Printing.Apis
GUID_DEVINTERFACE_IPPUSB_PRINT
Windows.Win32.Graphics.Printing.Apis
Windows.Win32.Graphics.Printing.Apis
NOTIFICATION_RELEASE
Windows.Win32.Graphics.Printing.Apis
Windows.Win32.Graphics.Printing.Apis
PRINT_APP_BIDI_NOTIFY_CHANNEL
Windows.Win32.Graphics.Printing.Apis
Windows.Win32.Graphics.Printing.Apis
PRINT_PORT_MONITOR_NOTIFY_CHANNEL
Windows.Win32.Graphics.Printing.Apis
Windows.Win32.Graphics.Printing.Apis