Skip to content

fix: tolerate invalid tool-call JSON in language model wrapper (fixes #322123) #322127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vs-code-engineering wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −4
Open

fix: tolerate invalid tool-call JSON in language model wrapper (fixes #322123) #322127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions extensions/copilot/src/extension/conversation/vscode-node/languageModelAccess.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,14 +834,19 @@ export class CopilotLanguageModelWrapper extends Disposable {
}
if (delta.copilotToolCalls) {
for (const call of delta.copilotToolCalls) {
// Anthropic models send "" (empty string) for tools with no parameters.
let parameters: object;
try {
// Anthropic models send "" (empty string) for tools with no parameters.
const parameters = JSON.parse(call.arguments || '{}');
progress.report(new vscode.LanguageModelToolCallPart(call.id, call.name, parameters));
parameters = JSON.parse(call.arguments || '{}');
} catch (err) {
// The model can stream malformed JSON for tool arguments. Log it for
// diagnostics and fall back to empty parameters so the tool call is still
// surfaced to the extension (matching other tool-call consumers) instead of
// leaking an unhandled rejection out of this fire-and-forget callback.
this._logService.error(err, `Got invalid JSON for tool call: ${call.arguments}`);
throw new Error('Invalid JSON for tool call');
parameters = {};
}
progress.report(new vscode.LanguageModelToolCallPart(call.id, call.name, parameters));
}
}

Expand Down
Loading