Restore file list when canceling folder creation in simple file dialog#320388
Merged
Conversation
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix file list restoration after canceling folder creation
Restore file list when canceling folder creation in simple file dialog
Jun 8, 2026
alexr00
approved these changes
Jun 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a UI regression in the workbench’s SimpleFileDialog where canceling the “Would you like to create it?” prompt (shown for non-existent folders) returns to the path input with an empty file/folder list due to QuickPick list state being shared across quick pick instances.
Changes:
- After re-showing the original file picker (
filePickBox) from the yes/no prompt’sonDidHide, forces a re-render of the picker’s items by re-assigningfilePickBox.itemsto itself.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/services/dialogs/browser/simpleFileDialog.ts | Forces the file picker to repopulate its shared QuickPick list after returning from the create-folder confirmation prompt. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
vritant24
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When opening a non-existent folder via the simple file dialog, the user is asked "Would you like to create it?". Canceling that prompt returned the user to the path input but with an empty file/folder list.
Root cause
QuickPickshares a single underlying UI list across instances. Showing the yes/no prompt replaces the list contents, andQuickPick.update()only re-pushes items to the UI whenitemsUpdatedis set — a flag toggled only by the items setter. Re-showing the original file picker therefore leaves the shared list empty.Changes
SimpleFileDialog.yesNoPrompt'sonDidHidehandler, after re-showingfilePickBox, reassign itsitemsto itself to flipitemsUpdatedand force the UI list to repopulate.