Add some tree sitter API tests #249078
Open
Add some tree sitter API tests #249078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive API tests for the tree-sitter integration in VS Code's workbench. The tests verify core tree-sitter functionality including parsing, tree editing, progress callbacks, and change detection.
Key Changes:
- Implements test suite for tree-sitter parser API functionality
- Tests parsing with progress callbacks and tree modification behaviors
- Validates change range detection across various editing scenarios
| modifiedTreeTwo?.delete(); | ||
| }); | ||
|
|
||
| test('Test getChangedRanges 3 - ranges are not as expected because the syntax doesn\'t change', async () => { |
There was a problem hiding this comment.
Corrected spelling of 'doesn't' to 'doesn't' (proper apostrophe character).
|
|
||
| // Add some backticks | ||
| const offsetRanges = [new OffsetRange(153, 153), new OffsetRange(271, 271)]; | ||
| const replacements = [new StringReplacement(offsetRanges[0], 'private x =`'), new StringReplacement(offsetRanges[1], '`')]; |
There was a problem hiding this comment.
The string 'private x =' has a missing space before the backtick which may be intentional for the test but appears inconsistent. Consider using 'private x = ' with a space before the backtick for better readability, unless the missing space is specifically required for the test case.
Suggested change
| const replacements = [new StringReplacement(offsetRanges[0], 'private x =`'), new StringReplacement(offsetRanges[1], '`')]; | |
| const replacements = [new StringReplacement(offsetRanges[0], 'private x = `'), new StringReplacement(offsetRanges[1], '`')]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.