Draft
Conversation
25ef340 to
7d27429
Compare
7d27429 to
27212fd
Compare
steinybot
commented
Feb 4, 2026
fs-provider/package-lock.json
Outdated
Author
There was a problem hiding this comment.
Deleted as I switched it to use npm workspaces with a shared lock file in the root.
steinybot
commented
Feb 4, 2026
Author
There was a problem hiding this comment.
It might not be the best idea to commit these but I figured I would leave them here for the review just to prove that it works.
Author
|
@microsoft-github-policy-service agree company="InterOperability Bidco, Inc., dba Rhapsody" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #165 with true Playwright integration.
I only just saw this comment #173 (comment) on the previous PR (which I forgot to close). I had actually given up on that one a while ago as it was fraught with issues. It was never going to be true Playwright integration. It didn't actually fix #165 since it couldn't take screenshots.
I've been working on this version for quite a while as it was tough to get the design right. The key insight is that Playwright already does the hard part in creating and serialising the handles. All this code is really doing is creating a clever proxy that allows you to use it as the original synchronous API in a fluent way which is actually all async underneath. Of course you have to await before you get a value but it's still much nicer that awaiting at each step. I'm very happy with how this turned out. The rest are the helpers to make it easy to add it as a test runner.
Now this is even more code so I know where this is going... well at least it is here for posterity. On your earlier question, with this version there actually isn't any changes to the original code so it likely is a lot easier to maintain as a separate library. I'll have to work on that next.