Skip to content

Full Playwright test integration#190

Draft
steinybot wants to merge 18 commits intomicrosoft:mainfrom
steinybot:playwright-test
Draft

Full Playwright test integration#190
steinybot wants to merge 18 commits intomicrosoft:mainfrom
steinybot:playwright-test

Conversation

@steinybot
Copy link

@steinybot steinybot commented Feb 4, 2026

Fixes #165 with true Playwright integration.

I only just saw this comment #173 (comment) on the previous PR (which I forgot to close). I had actually given up on that one a while ago as it was fraught with issues. It was never going to be true Playwright integration. It didn't actually fix #165 since it couldn't take screenshots.

I've been working on this version for quite a while as it was tough to get the design right. The key insight is that Playwright already does the hard part in creating and serialising the handles. All this code is really doing is creating a clever proxy that allows you to use it as the original synchronous API in a fluent way which is actually all async underneath. Of course you have to await before you get a value but it's still much nicer that awaiting at each step. I'm very happy with how this turned out. The rest are the helpers to make it easy to add it as a test runner.

Now this is even more code so I know where this is going... well at least it is here for posterity. On your earlier question, with this version there actually isn't any changes to the original code so it likely is a lot easier to maintain as a separate library. I'll have to work on that next.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted as I switched it to use npm workspaces with a shared lock file in the root.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might not be the best idea to commit these but I figured I would leave them here for the review just to prove that it works.

@steinybot
Copy link
Author

@microsoft-github-policy-service agree company="InterOperability Bidco, Inc., dba Rhapsody"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Web extension visual regression testing

1 participant