Add destination path validation for certificate deployment#2658
Open
lucygramley wants to merge 2 commits into
Open
Add destination path validation for certificate deployment#2658lucygramley wants to merge 2 commits into
lucygramley wants to merge 2 commits into
Conversation
Contributor
lucygramley
commented
May 21, 2026
lucygramley
commented
- Validate destination paths against allowed platform-specific directories before writing certificate files.
- Await CSR app name extraction before performing filesystem operations.
- Reject paths containing traversal sequences.
- Validate destination path against allowed platform-specific directories before writing certificate files - Await CSR app name validation before performing any filesystem operations - Reject paths containing traversal sequences Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
joj
approved these changes
May 27, 2026
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Thanks for the contribution and for working on certificate deployment path validation. Could you please create or link a corresponding issue for this PR? It would help us track the affected certificate deployment flow, the expected mitigation, and the platform-specific assumptions. The unit test pipeline is currently failing on Linux, Windows, and macOS. Could you please inspect the failing logs and update the PR? For this change, I would especially suggest adding or updating tests around the allowed destination paths for iOS, macOS, and Windows. The new allowlist looks fairly strict, so we should verify that valid simulator/device certificate deployment paths still work while traversal or unexpected paths are rejected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.