Merged
Conversation
Member
|
You may need to rebase after this other PR is merged for the Smoke test issue: 2b4c2bf |
amunger
added
the
skip package*.json
anthonykim1
reviewed
Sep 17, 2024
| indexedChildrenCount: number; | ||
| } | ||
|
|
||
| interface NotebookVariableProvider { |
There was a problem hiding this comment.
@amunger Does the vscode engine need to be explicitly pinned?
We currently have
"engines": {
"vscode": "^1.94.0-20240913"
},
also saw commit on vscode-distro so I think we are good.
Author
There was a problem hiding this comment.
just has to be beyond that distro commit, and that version is, so it should work
anthonykim1
reviewed
Sep 18, 2024
| function wrapScriptInFunction(scriptLines: string[]): string { | ||
| const indented = scriptLines.map((line) => ` ${line}`).join('\n'); | ||
| // put everything into a function scope and then delete that scope | ||
| // TODO: run in a background thread |
There was a problem hiding this comment.
Would running the script in the background give performance benefit?
Author
There was a problem hiding this comment.
having a large number of variables could conceivably block execution as they are collected and putting this operation on a background thread would prevent that. the speed of safeRepr might make that unnecessary though.
anthonykim1
approved these changes
Sep 18, 2024
This was referenced Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #24066