prioritize workspace selected env over process.env.CONDA_PREFIX#1398
Merged
eleanorjboyd merged 2 commits intomicrosoft:mainfrom Mar 25, 2026
Merged
prioritize workspace selected env over process.env.CONDA_PREFIX#1398eleanorjboyd merged 2 commits intomicrosoft:mainfrom
eleanorjboyd merged 2 commits intomicrosoft:mainfrom
Conversation
eleanorjboyd
added
the
bug
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes getCondaForWorkspace() so a persisted workspace-selected conda environment takes precedence over process.env.CONDA_PREFIX, matching the intended behavior described in issue #1347.
Changes:
- Reorders
getCondaForWorkspace()resolution logic to check persisted workspace selection before falling back toCONDA_PREFIX - Adds unit tests covering prioritization, fallback, and undefined cases
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/managers/conda/condaUtils.ts | Updates selection logic to prefer persisted workspace env over CONDA_PREFIX fallback |
| src/test/managers/conda/condaUtils.getCondaForWorkspace.unit.test.ts | Adds unit tests validating prioritization and fallback behaviors |
TylerLeonhardt
previously approved these changes
Mar 25, 2026
edvilme
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getCondaForWorkspace()prioritizesprocess.env.CONDA_PREFIXover the persisted workspace selection (commitb546ac4, PR #1243). This is atsrc/managers/conda/condaUtils.ts#L85-L87. Fix: swap the order so Memento state is checked first,CONDA_PREFIXis fallback only.fixes #1347