Fix spurious unresolved interpreter warning from ${workspaceFolder}-scoped global defaultInterpreterPath#1334
Merged
eleanorjboyd merged 2 commits intomicrosoft:mainfrom Mar 19, 2026
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
karthiknadig
previously approved these changes
Mar 17, 2026
src/features/interpreterSelection.ts
Outdated
| traceWarn( | ||
| `${logPrefix} defaultInterpreterPath '${userInterpreterPath}' contains unresolved variables, falling back to auto-discovery`, | ||
| if (!scope && userInterpreterPath.includes('${workspaceFolder}')) { | ||
| traceVerbose( |
Member
There was a problem hiding this comment.
May be we should explicitly return undefined here (after logging)?
Contributor
Author
There was a problem hiding this comment.
The intent was to skip ${workspaceFolder}-eval during global resolution & just fall through to Priority 4 auto-discovery w/o recording an error, rather than treating it as unresolved.
bpasero
previously approved these changes
Mar 17, 2026
eleanorjboyd
previously approved these changes
Mar 18, 2026
eleanorjboyd
dismissed stale reviews from bpasero, karthiknadig, and themself
via
54c55e8
rzhao271
approved these changes
Mar 18, 2026
eleanorjboyd
added
the
bug
Contributor
Author
|
@microsoft-github-policy-service agree |
alexdima
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1316. Skip evaluating
${workspaceFolder}-scopedpython.defaultInterpreterPathduring global resolution.