fix: address more Copilot review feedback

- Use relative imports in snapshot.py for proper package structure
- Add traceback.print_exc() for better CI debugging on failures
- Add test file patterns to _should_skip_file in git_analysis.py
- Include .tsx, .js, .jsx in complexity analysis (not just .ts)
- Update workflow to use 'python -m analysis.snapshot' invocation
- Update skill docs with new execution method

Author: karthiknadig

.github/skills/generate-snapshot/SKILL.md

@@ -19,13 +19,13 @@ This skill generates a comprehensive code health snapshot using the analysis mod
 ## How to Generate
 
 ```powershell
-cd analysis
-python snapshot.py --output ../analysis-snapshot.json
+# From repository root
+python -m analysis.snapshot --output analysis-snapshot.json
 ```
 
 Add `--pretty` flag to also print the JSON to stdout.
 
-**Note:** The snapshot is written to the repository root (`analysis-snapshot.json`), not inside the `analysis/` folder. This path is ignored by `.gitignore`.
+**Note:** The snapshot is written to the repository root (`analysis-snapshot.json`). This path is ignored by `.gitignore`.
 
 ## Snapshot Structure
 

.github/workflows/code-analysis.yml

@@ -31,9 +31,8 @@ jobs:
           uv pip install --system .
 
       - name: Generate snapshot
-        working-directory: analysis
         run: |
-          python snapshot.py --output ../analysis-snapshot.json
+          python -m analysis.snapshot --output analysis-snapshot.json
 
       - name: Upload snapshot artifact
         uses: actions/upload-artifact@v4

analysis/complexity_analysis.py

@@ -279,8 +279,8 @@ def analyze_complexity(repo_root: pathlib.Path) -> dict:
         if file_complexity:
             results["python"].append(file_complexity.to_dict())
 
-    # Analyze TypeScript files
-    ts_files = find_source_files(repo_root, [".ts"])
+    # Analyze TypeScript/JavaScript files
+    ts_files = find_source_files(repo_root, [".ts", ".tsx", ".js", ".jsx"])
     for filepath in ts_files:
         file_complexity = analyze_typescript_file(filepath, repo_root)
         if file_complexity:

analysis/git_analysis.py

@@ -207,6 +207,15 @@ def _should_skip_file(filepath: str) -> bool:
         ".git/",
         "package-lock.json",
         ".vsix",
+        # Skip test files and directories
+        "/test/",
+        "/tests/",
+        "/__tests__/",
+        ".test.",
+        ".spec.",
+        "_test.",
+        "_spec.",
+        "/mocks/",
     ]
     return any(pattern in filepath for pattern in skip_patterns)
 

analysis/snapshot.py

@@ -12,14 +12,15 @@
 import pathlib
 import subprocess
 import sys
+import traceback
 from datetime import datetime, timezone
 from typing import Optional
 
-# Import analysis modules
-from complexity_analysis import analyze_complexity
-from debt_indicators import analyze_debt
-from dependency_analysis import analyze_dependencies
-from git_analysis import analyze_repository as analyze_git
+# Import analysis modules (relative imports for package structure)
+from .complexity_analysis import analyze_complexity
+from .debt_indicators import analyze_debt
+from .dependency_analysis import analyze_dependencies
+from .git_analysis import analyze_repository as analyze_git
 
 # Snapshot schema version - increment when breaking changes are made
 SCHEMA_VERSION = "1.0.0"
@@ -285,6 +286,7 @@ def main() -> int:
         return 0
     except Exception as e:
         print(f"Error generating snapshot: {e}", file=sys.stderr)
+        traceback.print_exc()
         return 1