fix: address more Copilot review feedback

- Fix should_analyze_file() to use relative path parts instead of absolute
- Add [build-system] table to pyproject.toml for uv pip install
- Fix snapshot path in skill docs and session_start.py (use repo root)
- Rename open_issues_count to recent_issues_count (reflects --limit 5)

Author: karthiknadig

.github/hooks/scripts/session_start.py

@@ -89,7 +89,7 @@ def get_issue_context(repo_root: Path) -> Dict:
     if issues_json:
         try:
             issues = json.loads(issues_json)
-            context["open_issues_count"] = len(issues)
+            context["recent_issues_count"] = len(issues)
             context["recent_issues"] = [
                 f"#{i['number']}: {i['title']}" for i in issues[:3]
             ]
@@ -102,7 +102,7 @@ def get_issue_context(repo_root: Path) -> Dict:
 
 def get_snapshot_summary(repo_root: Path) -> Dict:
     """Get snapshot summary if available."""
-    snapshot_path = repo_root / "analysis" / "analysis-snapshot.json"
+    snapshot_path = repo_root / "analysis-snapshot.json"
     if not snapshot_path.exists():
         return {}
 
@@ -149,7 +149,7 @@ def main() -> int:
             parts.append(f"Uncommitted changes: {changes} files")
 
     if issue_context.get("recent_issues"):
-        parts.append(f"Open issues: {issue_context.get('open_issues_count', 0)}")
+        parts.append(f"Recent issues: {issue_context.get('recent_issues_count', 0)}")
 
     if snapshot_context:
         if snapshot_context.get("fixme_count", 0) > 0:

.github/skills/generate-snapshot/SKILL.md

@@ -20,11 +20,13 @@ This skill generates a comprehensive code health snapshot using the analysis mod
 
 ```powershell
 cd analysis
-python snapshot.py --output ./analysis-snapshot.json
+python snapshot.py --output ../analysis-snapshot.json
 ```
 
 Add `--pretty` flag to also print the JSON to stdout.
 
+**Note:** The snapshot is written to the repository root (`analysis-snapshot.json`), not inside the `analysis/` folder. This path is ignored by `.gitignore`.
+
 ## Snapshot Structure
 
 The snapshot contains these sections:

analysis/complexity_analysis.py

@@ -95,7 +95,9 @@ def should_analyze_file(
         ".git",
         ".vscode-test",
     }
-    for part in filepath.parts:
+    # Use relative path parts to avoid matching directories in repo root path
+    rel_parts = filepath.relative_to(repo_root).parts
+    for part in rel_parts:
         if part in skip_dirs:
             return False
 

analysis/debt_indicators.py

@@ -115,7 +115,9 @@ def should_analyze_file(
         ".git",
         ".vscode-test",
     }
-    for part in filepath.parts:
+    # Use relative path parts to avoid matching directories in repo root path
+    rel_parts = filepath.relative_to(repo_root).parts
+    for part in rel_parts:
         if part in skip_dirs:
             return False
 

analysis/dependency_analysis.py

@@ -89,7 +89,9 @@ def should_analyze_file(
         ".git",
         ".vscode-test",
     }
-    for part in filepath.parts:
+    # Use relative path parts to avoid matching directories in repo root path
+    rel_parts = filepath.relative_to(repo_root).parts
+    for part in rel_parts:
         if part in skip_dirs:
             return False
 

analysis/pyproject.toml

@@ -1,3 +1,7 @@
+[build-system]
+requires = ["hatchling"]
+build-backend = "hatchling.build"
+
 [project]
 name = "vscode-python-environments-analysis"
 version = "0.1.0"