fix: address remaining review comments (PR #1232)

- Add FileNotFoundError to get_git_info exception handling
- Ensure repo_root is absolute in resolve_import_path
- Fix misleading comment in stop_hook.py

Author: karthiknadig

.github/hooks/scripts/stop_hook.py

@@ -35,11 +35,11 @@ def has_uncommitted_changes(repo_root: Path) -> bool:
     """Check if there are uncommitted changes."""
     code, output = run_command(["git", "status", "--porcelain"], repo_root)
     if code == 0 and output:
-        # Filter out untracked files in certain directories
+        # Ignore all untracked files (marked with ??) - only track staged/modified
         lines = [
             line
             for line in output.split("\n")
-            if line.strip() and not line.strip().startswith("??")  # Ignore untracked
+            if line.strip() and not line.strip().startswith("??")
         ]
         return len(lines) > 0
     return False

analysis/dependency_analysis.py

@@ -148,6 +148,8 @@ def resolve_import_path(
 ) -> Optional[str]:
     """Resolve a relative import path to a workspace-relative path."""
     from_dir = from_file.parent
+    # Ensure repo_root is absolute for reliable relative_to() calls
+    repo_root = repo_root.resolve()
 
     # Handle the import path
     # Remove ./ or ../ prefixes and resolve

analysis/snapshot.py

@@ -72,7 +72,7 @@ def get_git_info(repo_root: pathlib.Path) -> dict:
             "branch": branch,
             "message": message[:200],  # Truncate long messages
         }
-    except (subprocess.CalledProcessError, subprocess.TimeoutExpired):
+    except (subprocess.CalledProcessError, subprocess.TimeoutExpired, FileNotFoundError):
         return {
             "sha": "unknown",
             "short_sha": "unknown",