Add 'terminalQuoteCharacter' to the debug configuration we send to debugpy #886
+318
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix microsoft/debugpy#1980, the debugger needs to quote the values it sends in the 'runInTerminal' request. However the quote being used depends upon the terminal that will eventually be used.
For example, quote a string this way:
will fail on powershell, but succeed on cmd.exe
Powershell requires single quotes like so:
This PR adds a new
terminalQuoteCharacterto the debug configuration we send to debugpy. A follow up PR in debugpy will use this value to properly quote arguments in the 'runInTerminal' reverse request.