Fix Windows binary path links in output log by appending .exe extension#779
Draft
Fix Windows binary path links in output log by appending .exe extension#779
Conversation
…on present Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com>
Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com>
Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix error dialog when opening app.exe path
Fix Windows binary path links in output log by appending .exe extension
Jan 30, 2026
Contributor
|
@copilot are any new tests to cover the scenario possible? |
Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com>
Contributor
Author
Added unit tests in commit 88755aa. The tests cover the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.exeextension in the output log causes "Unable to open 'app'" error because the actual file isapp.exesrc/parser.ts.exeextension on Windows when:-oor/outswitcheslinkerTargetBinaryandcompilerTargetBinarypaths from/Feswitchprocess.platform === "win32")path.extname()correctly returns empty string for paths without extensionChanges made:
Modified
src/parser.tsto append.exeextension on Windows when:/Fecompiler switch has no extension (inside existingprocess.platform === "win32"block)-oor/outlinker switches has no extension (with explicit platform check)Added unit tests in
src/test/fakeSuite/extension.test.ts:path.extnamebehavior with paths without extensionpath.extnamebehavior with paths with extensionNote: The Windows (mingw) test baselines may need to be updated when tests are run on Windows, as they currently reflect the old behavior without
.exeextension. This is expected behavior since the fix corrects the issue.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.