Skip to content

Fix parsing of environment variables with multiline values from preconfigure scripts #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix parsing of environment variables with multiline values from preconfigure scripts #762

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6ff795
Initial plan
Copilot Jan 23, 2026
8a56e4e
Fix parsing of environment from preconfigure script for multiline var…
Copilot Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/make.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1096,13 +1096,16 @@ export async function postConfigure(triggeredBy: TriggeredBy): Promise<number> {
// The input 'content' represents the output of a command that lists all the environment variables:
// set on windows or printenv on linux/mac.
async function applyEnvironment(content: string | undefined): Promise<void> {
let lines: string[] = content?.split(/\r?\n/) || [];
lines.forEach((line) => {
let eqPos: number = line.search("=");
// Sometimes we get a "" line and searching for = returns -1. Skip.
// On Linux/macOS, printenv -0 outputs NUL-separated entries to support multiline values
// (e.g., BASH_FUNC_* exported functions). On Windows, 'set' outputs newline-separated entries.
const separator = process.platform === "win32" ? /\r?\n/ : /\0/;
let entries: string[] = content?.split(separator) || [];
entries.forEach((entry) => {
let eqPos: number = entry.search("=");
// Sometimes we get a "" entry and searching for = returns -1. Skip.
if (eqPos !== -1) {
let envVarName: string = line.substring(0, eqPos);
let envVarValue: string = line.substring(eqPos + 1, line.length);
let envVarName: string = entry.substring(0, eqPos);
let envVarValue: string = entry.substring(eqPos + 1, entry.length);

// Only save to the modified environment values if it's different than the process.env.
if (!process.env[envVarName] || envVarValue !== process.env[envVarName]) {
Expand Down Expand Up @@ -1147,7 +1150,7 @@ export async function runPrePostConfigureScript(
wrapScriptContent = `source '${scriptFile}' ${
scriptArgs.length > 0 ? scriptArgs.join(" ").toString() : ""
}\n`;
wrapScriptContent += `printenv > '${wrapScriptOutFile}'`;
wrapScriptContent += `printenv -0 > '${wrapScriptOutFile}'`;
wrapScriptFile += ".sh";
}

Expand Down