Skip to content

Don't break when parsing partial JSON is invalid #3962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roblourens merged 2 commits into from
Feb 25, 2026
+6 −1
Merged

Don't break when parsing partial JSON is invalid #3962

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3d6625
Don't break when parsing partial JSON is invalid
roblourens Feb 24, 2026
6befd6b
comment
roblourens Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/extension/prompt/node/pseudoStartStopConversationCallback.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,5 +236,10 @@ function tryParsePartialToolInput(raw: string | undefined): unknown {
return raw;
}

return parsePartialJson(raw);
try {
// Certain patterns, especially partially-generated unicode escape sequences, cause this to throw.
return parsePartialJson(raw);
} catch {
return undefined;
}
Comment on lines +239 to +244
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixes a crash path, but there’s no unit test coverage for the new behavior. Consider adding a test that feeds a copilotToolCallStreamUpdates delta whose arguments includes an invalid/partial unicode escape (the known throw case) and asserts doProcessResponse doesn’t throw and continues streaming (e.g., updateToolInvocation is safely ignored or partialInput becomes undefined).

Copilot uses AI. Check for mistakes.
}