Address review feedback: IFileSystemService, log throttling, immutable prompt result#3961
Draft
Copilot wants to merge 2 commits intorosswollman/debug-prompt-override-filefrom
Draft
Address review feedback: IFileSystemService, log throttling, immutable prompt result#3961Copilot wants to merge 2 commits intorosswollman/debug-prompt-override-filefrom
Copilot wants to merge 2 commits intorosswollman/debug-prompt-override-filefrom
Conversation
…id mutating buildPromptResult Co-authored-by: rwoll <11915034+rwoll@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Allow static overrides of system prompts and tool descriptions
Address review feedback: IFileSystemService, log throttling, immutable prompt result
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses three review comments from #3959 on the
promptOverrideFiledebug setting.Use
IFileSystemService+URIinstead of NodefsapplyPromptOverridesnow acceptsUri+IFileSystemServiceinstead of a raw string path withfs.promises.readFileIFileSystemServiceinjected intoToolCallingLoopand propagated through all 4 subclasses (McpToolCallingLoop,CodebaseToolCallingLoop,DefaultToolCallingLoop,SearchSubagentToolCallingLoop)MockFileSystemServiceinstead ofvi.mock('fs')Throttle warning logs for unreadable override files
warn; repeated failures downgrade totracewarnAvoid mutating
buildPromptResultReplaced the type-cast mutation:
All downstream consumers (token counting,
_onDidBuildPrompt.fire,ResponseProcessorContext, fetch) now referenceeffectiveBuildPromptResult.Tests
vi.mock('fs')toMockFileSystemService💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.