-
Notifications
You must be signed in to change notification settings - Fork 76
pipelines: Major improvements #2174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bwateratmsft
wants to merge
28
commits into
main
Choose a base branch
from
bmw/pipelinesv2_2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bwateratmsft
commented
Jan 28, 2026
bwateratmsft
commented
Jan 28, 2026
Comment on lines
+109
to
+113
| # Invoke-Expression $commandLine # TODO: temporarily disabled for testing | ||
| # if ($LASTEXITCODE -ne 0) { | ||
| # Write-Error "Failed to publish VSIX: $($vsix.vsixName)" | ||
| # exit 1 | ||
| # } |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: reenable
Suggested change
| # Invoke-Expression $commandLine # TODO: temporarily disabled for testing | |
| # if ($LASTEXITCODE -ne 0) { | |
| # Write-Error "Failed to publish VSIX: $($vsix.vsixName)" | |
| # exit 1 | |
| # } | |
| Invoke-Expression $commandLine | |
| if ($LASTEXITCODE -ne 0) { | |
| Write-Error "Failed to publish VSIX: $($vsix.vsixName)" | |
| exit 1 | |
| } |
bwateratmsft
commented
Jan 28, 2026
bwateratmsft
commented
Jan 28, 2026
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Need to create the branch ruleset
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…de-azuretools into bmw/pipelinesv2_2
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…de-azuretools into bmw/pipelinesv2_2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2173
Example PRs using these:
Successful builds using these:
Successful releases using these: