Esbuild migration work #1005
Open
Esbuild migration work #1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint.config.mjs
Outdated
Comment on lines
10
to
12
| globalIgnores([ | ||
| 'test/testProjects/**', | ||
| ]), |
Contributor
There was a problem hiding this comment.
I'd be fine with adding this path to the shared pkg too.
Contributor
Author
There was a problem hiding this comment.
I think in static web apps the path is 'test/testProject/**' should I add this path to the shared package as well?
Contributor
There was a problem hiding this comment.
Yeah, or rename the folder in SWA
bwateratmsft
approved these changes
Jan 21, 2026
package.json
Outdated
| "@vscode/test-electron": "*", | ||
| "@vscode/vsce": "*", | ||
| "esbuild": "*", | ||
| "esbuild-plugin-copy": "^2.1.1", |
Contributor
There was a problem hiding this comment.
I'd keep * version for this one and leave control of the version to the eng pkg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the bulk of the migration work. I am still working on fixing some errors including lint and build errors. I'll put those in seperate PR's that merge into this branch before merging this.
Todo: