Fix qualified PackageSpec parse hang. #1872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
commented
Dec 3, 2025
| int depth = 1; | ||
| while (depth > 0 && (ch = parser.next()) != 0) | ||
| ch = parser.next(); | ||
| if (ch == '\r' || ch == '\n' || ch == Unicode::end_of_file) |
Member
Author
There was a problem hiding this comment.
This is technically a behavior change to no longer accept newlines but ~every real use case here already won't practically allow newlines and this makes the diagnostics better.
vicroms
approved these changes
Dec 3, 2025
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Dec 5, 2025
https://github.com/microsoft/vcpkg-tool/releases/tag/2025-12-05 * Bump js-yaml from 4.1.0 to 4.1.1 in /vcpkg-artifacts by @dependabot[bot] in microsoft/vcpkg-tool#1847 * Bump glob from 10.4.5 to 10.5.0 in /vcpkg-artifacts by @dependabot[bot] in microsoft/vcpkg-tool#1857 * Test parent hashes without actual build by @dg0yt in microsoft/vcpkg-tool#1870 * Fix qualified PackageSpec parse hang. by @BillyONeal in microsoft/vcpkg-tool#1872 * Test --skip-failures and fix "static" cascade by @dg0yt in microsoft/vcpkg-tool#1871 * Update scripts SHA 2025-12-03 and update github actions runners. by @BillyONeal in microsoft/vcpkg-tool#1873 Thanks for the `ci` improvements @dg0yt !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See microsoft/vcpkg#48578 (comment)