Skip to content

[Python] Enhance XML deserialization logic for model_base template #9637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
annatisch wants to merge 2 commits into from
+12 −0
Closed

[Python] Enhance XML deserialization logic for model_base template #9637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06c2d89
Enhance XML deserialization logic for model_base template
annatisch Feb 9, 2026
fc5db38
Update changes
annatisch Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .chronus/changes/annatisch-patch-1-2026-1-9-5-25-35.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
# Change versionKind to one of: internal, fix, dependencies, feature, deprecation, breaking
changeKind: fix
packages:
- "@typespec/http-client-python"
---

[Python] Enhance XML deserialization logic in model_base template
4 changes: 4 additions & 0 deletions packages/http-client-python/generator/pygen/codegen/templates/model_base.py.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,11 +1020,15 @@ def _deserialize_with_callable(
return float(value.text) if value.text else None
if deserializer is bool:
Copy link
Member

@l0lawrence l0lawrence Feb 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add ->

else:
dict_to_pass[rf._rest_name] = []

on line 635? If an unwrapped element is an empty array do we return None or []?

Copy link
Member

@l0lawrence l0lawrence Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/microsoft/typespec/pull/9778/files

return value.text == "true" if value.text else None
if deserializer in _DESERIALIZE_MAPPING.values() or deserializer in _DESERIALIZE_MAPPING_WITHFORMAT.values():
return typing.cast(typing.Callable[[typing.Any], typing.Any], deserializer)(value.text) if value.text else None
if deserializer is None:
return value
if deserializer in [int, float, bool]:
return deserializer(value)
if isinstance(deserializer, CaseInsensitiveEnumMeta):
if isinstance(value, ET.Element):
value = value.text if value.text else None
try:
return deserializer(value)
except ValueError:
Expand Down
Loading