Fix CommonJS export destructuring emit#4404
Open
jakebailey wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds regression coverage (and a small transformer fix) for a CommonJS emit bug where module-scope export const { … } = <importedValue> could lose the import namespace qualification on the RHS, leading to a runtime ReferenceError at module load (Fixes #4403).
Changes:
- Fix CommonJS module transformer ancestor tracking when converting exported binding-pattern variable declarations into destructuring assignments.
- Add a compiler repro test covering exported destructuring from imported values under
--module commonjs(including array/object patterns, aliasing, default import, and default initializers). - Add an additional compiler test ensuring namespace-export destructuring preserves correct qualified references inside the namespace.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
internal/transformers/moduletransforms/commonjsmodule.go |
Push/pop ancestor stack around synthesized destructuring assignment so identifier reference substitution (imports/exports) runs with the correct parent context. |
testdata/tests/cases/compiler/commonjsExportDestructuringImportedValue.ts |
New regression test for CommonJS emit of export const {…} = importedValue (and related destructuring cases). |
testdata/baselines/reference/compiler/commonjsExportDestructuringImportedValue.js |
Baseline validating RHS stays qualified (e.g. enum_1.CodePriceType) in emitted CommonJS output. |
testdata/tests/cases/compiler/namespaceExportDestructuringReferences.ts |
New test ensuring namespace export destructuring uses the namespace-qualified references for computed names and default initializers. |
testdata/baselines/reference/compiler/namespaceExportDestructuringReferences.js |
Baseline validating correct namespace-qualified emit (N.key, N.fallback, etc.). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4403