Skip to content

fix(relater): add property comparison cache fast path to avoid false TS2321 #4382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maoger wants to merge 2 commits into
base: main
Choose a base branch
from
+7,010 −0
Open

fix(relater): add property comparison cache fast path to avoid false TS2321 #4382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7102c4
fix(relater): add property comparison cache fast path to avoid false …
maoger Jun 20, 2026
a997839
test: add regression test for large object literal type comparison
maoger Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions internal/checker/relater.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4332,6 +4332,17 @@ func (r *Relater) isPropertySymbolTypeRelated(sourceProp *ast.Symbol, targetProp
return TernaryTrue
}
effectiveSource := getTypeOfSourceProperty(sourceProp)
// Fast path: query the relation cache directly before entering the recursive comparison
// path. This avoids the overhead of calling into isRelatedToEx and its normalization
// logic when the result is already cached (e.g. for repeated property types like string
// or "off"|"warn"|"error" across 100+ properties in large object literals).
if effectiveSource.flags&TypeFlagsObject != 0 && effectiveTarget.flags&TypeFlagsObject != 0 {
id, _ := getRelationKey(effectiveSource, effectiveTarget, intersectionState, r.relation == r.c.identityRelation, false /*ignoreConstraints*/)
if entry := r.relation.get(id); entry != RelationComparisonResultNone && entry&RelationComparisonResultSucceeded != 0 {
r.c.reliabilityFlags |= entry & (RelationComparisonResultReportsUnmeasurable | RelationComparisonResultReportsUnreliable)
return TernaryTrue
}
}
return r.isRelatedToEx(effectiveSource, effectiveTarget, RecursionFlagsBoth, reportErrors, nil /*headMessage*/, intersectionState)
}

Expand Down
Loading