Fix watch coalescing for FSEvents#4379
Draft
jakebailey wants to merge 4 commits into
Draft
Conversation
Coalesce dense directory watch sets into recursive ancestor watches on fast-recursive backends such as FSEvents and Windows. This avoids opening one stream per dependency directory while still surfacing startup failures.
Member
Author
|
This is doing this in the layer above fswatch, but, going to try and shove it down... |
Consolidate dense directory subscriptions inside fswatch for fast recursive backends. Parent streams now serve later child subscriptions with per-subscriber filtering, so all fswatch callers benefit without watch-manager-specific planning.
Add a tsc watch integration baseline covering many dependency files under a Bun-style node_modules/.bun layout. The lower-level fswatch tests assert stream coalescing; this keeps the command-line watch shape covered end-to-end.
# Conflicts: # internal/fswatch/watcher.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4378
Coalesce dense directory watch sets into recursive ancestor watches on fast-recursive backends such as FSEvents and Windows. This avoids opening one stream per dependency directory while still surfacing startup failures.