Fix namespaced JSX intrinsic completions and hover#4366
Open
Copilot wants to merge 4 commits into
Open
Conversation
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing completion and hover document for namespaced JSX elements
Fix namespaced JSX intrinsic completions and hover
Jun 18, 2026
jakebailey
approved these changes
Jun 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes language-service hover and completions for namespaced JSX intrinsic elements (e.g. <foo:bar />) by ensuring the LS uses the normalized “quick info” node for symbol resolution and by treating JsxNamespacedName (and its identifiers) as valid JSX element contexts for completion.
Changes:
- Adjust hover symbol resolution to use the normalized quick-info node (improves hover on
JsxNamespacedNameand related nodes likeimport.meta). - Extend JSX completion context detection to handle
JsxNamespacedNameand its child identifiers, restoring intrinsic attribute completions. - Add/refresh fourslash coverage and update quick-info baselines for the corrected hover output.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
internal/ls/hover.go |
Uses the normalized quick-info node for symbol lookup so hover info matches the displayed range/node. |
internal/ls/completions.go |
Treats JsxNamespacedName and identifiers within it as valid JSX opening-element contexts for attribute completions. |
internal/fourslash/tests/quickInfoJsxNamespacedIntrinsic_test.go |
New regression test for quick info on namespaced JSX intrinsic tags/attributes. |
internal/fourslash/tests/completionsInJsxTag_test.go |
New regression test for intrinsic attribute completions on namespaced JSX intrinsic tags. |
testdata/baselines/reference/fourslash/quickInfo/quickInfoOnJsxNamespacedName.baseline |
Baseline update: quick info now produced for the full namespaced tag. |
testdata/baselines/reference/fourslash/quickInfo/quickInfoImportMeta.baseline |
Baseline update: hover now resolves to ImportMeta interface docs (consistent with normalized-node symbol resolution). |
| <foo:ba/*tag*/r fo/*attr*/o />` | ||
| f, done := fourslash.NewFourslash(t, nil /*capabilities*/, content) | ||
| defer done() | ||
| f.VerifyQuickInfoAt(t, "tag", "(property) JSX.IntrinsicElements[\"foo:bar\"]: {\n foo: boolean;\n bar: string;\n}", "Element docs") |
Member
|
@copilot a now non-failing test needs to be removed from internal/fourslash/_scripts/failingTests.txt |
The hover.go fix (using rangeNode for symbol lookup) now makes TestQuickInfoOnNewKeyword01 pass, so it no longer needs to be listed as a failing test. Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Contributor
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Namespaced JSX intrinsic elements such as
<foo:bar />type-check correctly, but the language service missed attribute completions and hover info for the tag and its attributes.Completions
Treat
JsxNamespacedNametag nodes, and their child identifiers, as valid JSX opening-element contexts.Restores intrinsic attribute completions in positions like:
Hover
Coverage