Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a few incorrect string-iteration behaviors in the Go port that stem from accidentally iterating by runes (UTF-8 code points) when the code expects byte indexing, and updates the affected fourslash baseline output accordingly.
Changes:
- Fix an off-by-one error in
TruncateByRunesso truncation occurs aftermaxLengthrunes, not before. - Make stack-trace whitespace scanning use byte indexing rather than rune iteration.
- Fix glob
*backtracking to iterate byte positions (not rune start offsets), aligning with the matcher’s byte-oriented indexing.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| testdata/baselines/reference/fourslash/documentSymbols/navigationBarItemsMultilineStringIdentifiers3.baseline | Updates expected output to reflect corrected truncation behavior. |
| internal/stringutil/util.go | Corrects TruncateByRunes truncation boundary (>= → >). |
| internal/lsp/stack_sanitizer.go | Uses byte-index loop when skipping leading whitespace on stack trace lines. |
| internal/glob/glob.go | Changes * backtracking loop to iterate by byte offset rather than rune boundaries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote a lint rule to complain on all "ranges over string", then looked at each case. These three were bugs.