Process @overload tags only in limited contexts
#2263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahejlsberg
requested review from
Copilot,
jakebailey and
sandersn
and removed request for
Copilot
jakebailey
approved these changes
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes our reparsing logic to only create synthetic overload declarations when
@overloadtags occur on function, method, or constructor declarations outside object literals.The PR also fixes incorrect
parsingContextsflag setting logic that apparently wasn't breaking anything.With this PR we're no longer dumping overload signatures into the global scope in declarations files as can be seen in the baseline changes for
jsFileAlternativeUseOfOverloadTag.js.This PR supersedes #2221, which BTW doesn't work because it relies on following parent pointers that aren't yet set.
Fixes #2218.