Port "fix(60592): JSDoc implements space sensetive" #1066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Oleksandr T <oleksandr.tarasiuk@outlook.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ports a fix for a JSDoc space sensitivity issue by ensuring the parser skips any intervening whitespace before consuming a closing brace.
- Added a call to skip whitespace before parsing the closing brace in JSDoc expressions.
jakebailey
approved these changes
Jun 5, 2025
Copilot AI
added a commit
that referenced
this pull request
Jan 21, 2026
This file demonstrates a performance bug where nested spread operations
on discriminated union types with intersection base types cause
exponential type checking time. The file takes ~21s to check with tsgo
when it should take < 1s.
Key elements of the repro:
- 11 different settings types with nested {input: {...}} structure
- A union type with intersection of Base & specific settings
- Triple nested spread: ...step, ...step.settings, ...step.settings.input
- Generic read<T> function to capture the complex type
Related to: #1066
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ports microsoft/TypeScript#60640