osmodifier: [last follow-up] remove all orphaned osmodifier references#668
Merged
Conversation
Member
Author
|
/azp run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
fintelia
approved these changes
May 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes leftover references to the legacy Go osmodifier binary across tooling, pipelines, and documentation, aligning the repo with the current Rust osmodifier library usage.
Changes:
- Removes
osmodifiercopy/config support fromnetlaunch(config struct, CLI flag, and RCP injection). - Deletes the
Dockerfile-osmodifier.azl3and removesosmodifierbuild instructions from developer docs. - Simplifies Azure Pipelines templates by removing
osModifier*parameters and thedownload-osmodifier.ymltemplate; drops an unusedtrident_apierror variant.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/pkg/netlaunch/netlaunch.go | Stops registering/copying an osmodifier binary via RCP agent config injection. |
| tools/pkg/netlaunch/config.go | Removes localOsmodifierPath from RcpConfiguration. |
| tools/cmd/netlaunch/main.go | Removes --osmodifier-binary flag and related wiring/validation. |
| packaging/docker/Dockerfile-osmodifier.azl3 | Deletes Dockerfile previously used to build the Go osmodifier binary. |
| docs/Development/Testing/Functional-Tests.md | Removes osmodifier build step from functional test dependency build instructions. |
| docs/Development/Testing/E2E-Tests.md | Removes osmodifier build section and updates RPM build text accordingly. |
| docs/Development/Building/Dependencies.md | Removes “(for osmodifier)” qualifier from Go requirement. |
| docs/Development/Building/Building.md | Removes the “Building OS Modifier” section. |
| crates/trident_api/src/error.rs | Removes the unused FindOSModifierBinary enum variant. |
| .pipelines/trident-cicd-for-prism.yml | Drops osModifierBranch parameter plumbing. |
| .pipelines/templates/trident-platform-cicd-for-prism-template.yml | Drops osModifierBranch parameter plumbing. |
| .pipelines/templates/stages/validate_makefile/dev-build.yml | Removes osModifierBranch parameter definition. |
| .pipelines/templates/stages/trident_rpms/trident-stage.yml | Removes osModifierBranch parameter and related build-type selection logic. |
| .pipelines/templates/stages/trident_rpms/build-source.yml | Removes osModifierBranch / osModifierBuildType parameters. |
| .pipelines/templates/stages/testing_functional/functional-testing.yml | Removes osModifierBranch parameter definition. |
| .pipelines/templates/stages/common_tasks/download-osmodifier.yml | Deletes template used to build/download osmodifier. |
| .pipelines/templates/e2e-template.yml | Removes osModifierBranch parameter and all pass-throughs. |
| .pipelines/templates/e2e-arm64-template.yml | Removes osModifierBranch parameter and pass-through. |
Comments suppressed due to low confidence (1)
docs/Development/Testing/E2E-Tests.md:100
- Step numbering is now inconsistent after removing the former “### 3. Build osmodifier” section (it jumps from 2 to 4). Renumber this heading (and subsequent step headings) so the sequence remains correct.
### 4. Build Trident RPMs
The test images include Trident packages built from your local tree. This step
builds the RPMs into `bin/RPMS/`, which `testimages.py` passes to Image
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 Description
Remove unused code and references related to golang osmodifier.