build: use imagecustomizer container for MOS ISO build#653
Merged
Conversation
Member
Author
|
/azp run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
fintelia
previously approved these changes
May 22, 2026
frhuelsz
previously approved these changes
May 23, 2026
Contributor
frhuelsz
left a comment
frhuelsz
left a comment
There was a problem hiding this comment.
note-to-future-selves: use the python-based in the builder for this image too
bfjelds
force-pushed
the
user/bfjelds/mjolnir/e2e-doc-rewrite
branch
from
70cade1 to
51463ba
Compare
bfjelds
force-pushed
the
user/bfjelds/mjolnir/mic-container-mos-iso
branch
from
133bd2d to
7a4567c
Compare
bfjelds
force-pushed
the
user/bfjelds/mjolnir/e2e-doc-rewrite
branch
from
51463ba to
e5902b4
Compare
bfjelds
force-pushed
the
user/bfjelds/mjolnir/mic-container-mos-iso
branch
2 times, most recently
from
422634d to
e6d3b7d
Compare
bfjelds
force-pushed
the
user/bfjelds/mjolnir/e2e-doc-rewrite
branch
from
83b67b8 to
3d491ca
Compare
Replace the binary imagecustomizer (downloaded from ADO artifacts feed via az CLI) with a docker run invocation using the MIC_CONTAINER_IMAGE container, consistent with how all other image builds work. This removes the artifacts/imagecustomizer target and MIC_PACKAGE_NAME/ MIC_PACKAGE_VERSION variables, eliminating the az CLI dependency for local builds. Also removes the now-unnecessary imagecustomizer extraction step from E2E-Tests.md. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bfjelds
force-pushed
the
user/bfjelds/mjolnir/mic-container-mos-iso
branch
from
e6d3b7d to
f2dadb3
Compare
bfjelds
changed the base branch from
user/bfjelds/mjolnir/e2e-doc-rewrite
to
main
bfjelds
dismissed stale reviews from frhuelsz and fintelia
The base branch was changed.
Member
Author
|
/azp run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
fintelia
approved these changes
May 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the local MOS installer ISO build flow to use the Image Customizer container directly (via docker run) instead of downloading/executing a standalone imagecustomizer binary, and removes the corresponding documentation step that required extracting the binary.
Changes:
- Remove the
az artifacts universal download-basedartifacts/imagecustomizertarget and related variables from the Makefile. - Build
bin/trident-mos.isoby running the Image Customizer container ($(MIC_CONTAINER_IMAGE)) with the repo bind-mounted into the container. - Update E2E documentation to remove the “Extract Image Customizer” step and renumber subsequent steps.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Makefile | Switch bin/trident-mos.iso generation from a downloaded binary to a docker run using $(MIC_CONTAINER_IMAGE); removes the az-download target. |
| docs/Development/Testing/E2E-Tests.md | Removes the manual Image Customizer binary extraction step since the Makefile now uses the container directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the standalone
imagecustomizerbinary download with adocker runinvocation of the Image Customizer container for thebin/trident-mos.isoMakefile target.Changes
Makefile
MIC_PACKAGE_NAMEandMIC_PACKAGE_VERSIONvariables (no longer needed)artifacts/imagecustomizerdownload targetsudo ./artifacts/imagecustomizerinvocation withdocker run --rm --privilegedusing$(MIC_CONTAINER_IMAGE)/repoand use/buildas the container-internal build directoryartifacts/imagecustomizerfrom thecleantargetdocs/Development/Building/E2E-Tests.md
Motivation
azCLI dependency for local MOS ISO builds (the binary download requiredaz acr login)$(MIC_CONTAINER_IMAGE)make bin/trident-mos.isojust works with DockerTesting
make bin/trident-mos.isoStacking
This PR is stacked on #652 (E2E doc rewrite).