Skip to content

Add mapping for extension methods#176

Open
rcrxy wants to merge 2 commits intomicrosoft:mainfrom
rcrxy:extension-method
Open

Add mapping for extension methods#176
rcrxy wants to merge 2 commits intomicrosoft:mainfrom
rcrxy:extension-method

Conversation

@rcrxy
Copy link
Copy Markdown

@rcrxy rcrxy commented Dec 8, 2025

Add mapping for extension methods

This pull request adds mapping for extension methods to improve compatibility and conversion accuracy when translating VS Code color themes to VS 2022 color themes.

  • Implemented extension method mappings in the relevant converter logic.
  • This update helps ensure extension methods are correctly handled during the conversion process and enhances theme fidelity.
  • If applicable, addresses related issue: #172.

Copilot AI review requested due to automatic review settings December 8, 2025 13:32
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds mapping for VS Code's entity.name.function.extension token to Visual Studio 2022's extension method name token, improving theme conversion accuracy for C# extension methods.

Key Changes

  • Added mapping entry for extension methods in TokenMappings.json, translating entity.name.function.extension from VS Code themes to Visual Studio's text editor token

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ThemeConverter/ThemeConverter/TokenMappings.json Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Fasteroid
Copy link
Copy Markdown

Fasteroid commented Jan 27, 2026

Fixed my theme port with this, ur a lifesaver. Thanks!

@vkuharsky
Copy link
Copy Markdown

Can someone review this?

Copy link
Copy Markdown
Author

@rcrxy rcrxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add mapping for extension methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants