Update profile subpages#20336
Open
carlos-zamora wants to merge 3 commits into
Open
Conversation
Member
Author
DemoProfiles_Base
Profiles_UnfocusedAppearance
Tooltips
|
carlos-zamora
commented
Jun 18, 2026
Comment on lines
+397
to
+402
|
|
||
| // Optional resource name for a secondary label shown beneath the primary label in | ||
| // search results (i.e. "Nav_ProfileDefaults/Content" for the profile-defaults page links). | ||
| // Empty for most entries. | ||
| // NOTE: wrapped in USES_RESOURCE() (when set) for the same compile-time validation as ResourceName. | ||
| wil::zwstring_view SecondaryResourceName; |
Member
Author
There was a problem hiding this comment.
The SecondaryResourceName changes in this file conflict with #20199 . They both have basically the same implementation with a different variable name. The consumer in SearchIndex.cpp also needs to be updated.
I'll go in and make this match the one from the other one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Updates the individual profile pages to include:
Detailed Description of the Pull Request / Additional comments
IInheritableViewModel: interface exposingHasSetting(),ClearSetting(), andSettingOverrideSource()Profiles_UnfocusedAppearance.h/cpp/idl/xaml: the new unfocused appearance pageValidation Steps Performed
PR Checklist
Related to #17000