Conversation
| SettingsNav().SelectedItem(firstItem); | ||
| _Navigate(firstItem.Tag(), BreadcrumbSubPage::None); | ||
|
|
||
| _UpdateSearchIndex(); |
There was a problem hiding this comment.
(updating the index post-navigation?)
There was a problem hiding this comment.
This is the one in UpdateSettings(). We discussed offline that we do still need this, but we both forgot why haha. That said, the whole point of the build time index is that it's not supposed to change.
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
carlos-zamora
force-pushed
the
dev/cazamor/sui/refactor-navigation
branch
from
7496435 to
f2f5ec9
Compare
microsoft-github-policy-service
bot
removed
the
Needs-Author-Feedback
|
^ that force-push was a |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Method Description: | ||
| // - Navigates to the page corresponding to the given nav tag. Updates the breadcrumb bar and selected nav view item accordingly. | ||
| // Arguments: | ||
| // - vm: the nav tag of the page to navigate to. Can be either an hstring for static pages or |
Check failure
Code scanning / check-spelling
Forbidden Pattern Error
There was a problem hiding this comment.
i'm guessing it means "an hstring" is illegal
There was a problem hiding this comment.
this bothers me more than it should haha
This comment was marked as resolved.
This comment was marked as resolved.
| { | ||
| // Used to trigger the PropertyChanged handler in MainPage.cpp | ||
| // This forces the page to refresh | ||
| _NotifyChanges(L"CurrentPage"); |
There was a problem hiding this comment.
huh, what was this for/where did it go?
There was a problem hiding this comment.
_Navigate() now supports navigating to subpages directly, so we have no need for the force refresh functionality anymore.
DHowett
left a comment
DHowett
left a comment
There was a problem hiding this comment.
LFG. Does this fix the issue where you can't navigate into Edit Action more than once?
Yes! That sounds familiar! |
2 participants
Summary of the Pull Request
Consolidates the navigation functions in
MainPagefor the settings UI. This involved:_Navigate()functions into one big oneSettingsNav().SelectedItem()callselementToFocusstaging behavior for color schemes and profile sub pagesReferences and Relevant Issues
Builds off the work done in #19519 and #19831
Validation Steps Performed
Navigate to...
✅ simple top-level pages: Startup, Interaction, Appearance, Rendering, Compatibility, Add profile
✅ Color schemes and subpages
✅ Actions, subpages
✅ New Tab Menu and folder subpages
✅ Extensions, subpages, and profile/scheme navigation
✅ defaults profile and subpages
✅ specific profile and subpages
Also tested discarding changes on these pages.
✅ search still works and navigates to the correct element
PR Checklist
Closes #19866