Add setting for customizable delimiter for file drag-and-drop#19799
Open
Vallabh-1504 wants to merge 2 commits intomicrosoft:mainfrom
Open
Add setting for customizable delimiter for file drag-and-drop#19799Vallabh-1504 wants to merge 2 commits intomicrosoft:mainfrom
Vallabh-1504 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
9bdc131 to
21e4b1a
Compare
21e4b1a to
fb30903
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR introduces a new profile setting,
dragDropDelimiter, which allows users to configure the string separator used when dragging and dropping multiple files into the terminal. The default behavior remains a single space (" ") for backward compatibility.References and Relevant Issues
Detailed Description of the Pull Request / Additional comments
Implementation Details:
DragDropDelimitertoMTSMSettings.handProfile.idl.ControlProperties.hso the terminal logic can see it.TermControl::OnDropto use the new delimiter when joining paths.Demo
demo1.mp4
Validation Steps Performed
dragDropDelimiterto", ",";", and custom strings insettings.jsonand from settings UI.Notes for Reviewers
Resources/en-USfile.ProfileViewModel.cpp, I added theelse ifblock for the new setting, but left it empty because no other UI logic currently depends on it.PR Checklist