.Net: Implement SQL Server hybrid search#13512
Open
roji wants to merge 2 commits intomicrosoft:mainfrom
Open
Conversation
github-actions
bot
changed the title
adamsitnik
approved these changes
Feb 6, 2026
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, I had some comments, but none of them were blocking. Thank you @roji !
| FROM sys.fulltext_indexes fi | ||
| JOIN sys.tables t ON fi.object_id = t.object_id | ||
| WHERE t.name = @tableName | ||
| AND fi.has_crawl_completed = 0"; |
Member
There was a problem hiding this comment.
Just for my education: is this the recommended way of doing it? I am not a DB expert, so it just looks fishy to me ;P
Member
Author
There was a problem hiding this comment.
Anything in particular? :) The problem is that the creation of full-text indexes happens asynchronously, so we need to wait until they are done. This kind of thing is frequently a problem when writing tests that involve databases, unfortunately.
On the upside, this is only test infra code, so not very important.
dotnet/test/VectorData/SqlServer.ConformanceTests/Support/SqlServerTestStore.cs
Outdated
Show resolved
Hide resolved
dotnet/test/VectorData/SqlServer.ConformanceTests/Support/SqlServerTestStore.cs
Outdated
Show resolved
Hide resolved
markwallace-microsoft
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11080