Fix HTML autotrim bug - respect directory boundaries when computing common prefix#93
Draft
Fix HTML autotrim bug - respect directory boundaries when computing common prefix#93
Conversation
Co-authored-by: gramster <2762632+gramster@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] HTML autotrim bug
Fix HTML autotrim bug - respect directory boundaries when computing common prefix
May 28, 2025
|
fixes #110 oops. lgtm??? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTML autotrim feature was incorrectly computing common prefixes that could end in the middle of directory names, causing partial directory names to be stripped from file paths.
Problem
When multiple SARIF results had file paths with similar prefixes that didn't align with directory boundaries, the autotrim logic would compute a common prefix that cut through directory names. For example:
Input paths:
Before fix: Common prefix computed as
tools/bin/Redacte, resulting in broken output:After fix: Common prefix computed as
tools/bin/, resulting in correct output:Solution
Modified the
init_path_prefix_strippingmethod insarif_file.pyto ensure that computed common prefixes always end at directory boundaries (slashes). The fix:Testing
Added comprehensive tests covering:
All existing tests continue to pass, ensuring no regressions.
Fixes #85.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.