Skip to content

Remove unused @rushstack/rush-sdk dependency from webpack5/rspack everything-test build-tests#5706

Draft
Copilot wants to merge 5 commits intomainfrom
copilot/clean-up-rush-sdk-dependency
Draft

Remove unused @rushstack/rush-sdk dependency from webpack5/rspack everything-test build-tests#5706
Copilot wants to merge 5 commits intomainfrom
copilot/clean-up-rush-sdk-dependency

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 20, 2026

  • Remove @rushstack/rush-sdk from heft-webpack5-everything-test/package.json
  • Remove @rushstack/rush-sdk from heft-rspack-everything-test/package.json
  • Rebase onto latest main and run rush update to regenerate the lockfile from a clean state

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Copilot AI and others added 2 commits March 17, 2026 00:33
…thing-test and heft-rspack-everything-test

Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
@dmichon-msft
Copy link
Copy Markdown
Contributor

@copilot You need to run rush update after making this change.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 20, 2026

@copilot You need to run rush update after making this change.

Done — ran rush update --subspace default which removed the @rushstack/rush-sdk entries from common/config/subspaces/default/pnpm-lock.yaml for both projects. Committed in 3bc8b9f.

eslint@8.57.1:
dependencies:
'@eslint-community/eslint-utils': 4.9.1(eslint@8.57.1)
'@eslint-community/eslint-utils': 4.9.1(eslint@9.37.0)
Copy link
Copy Markdown
Contributor

@dmichon-msft dmichon-msft Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot This can't possibly be right. The consuming package is eslint@8.57.1, the peer therefore must resolve to eslintg@8.57.1.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 11a698a — reverted the snapshot back to 4.9.1(eslint@8.57.1). This was a spurious change introduced by rush update.

…nt@8.57.1

Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/4c5c525a-b587-4a90-8705-599905da6580

Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
@dmichon-msft
Copy link
Copy Markdown
Contributor

@copilot Rebase this PR onto latest main, discard this branch's modifications under common/config/subspaces/ and rerun rush update, then commit the results.

Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/013e73b8-ad42-4b51-a483-1ffefa03fe4d

Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 7, 2026

@copilot Rebase this PR onto latest main, discard this branch's modifications under common/config/subspaces/ and rerun rush update, then commit the results.

Done in 5a1edfa. Rebased onto latest main, reset common/config/subspaces/ to the main state, and ran rush update. Note that pnpm itself produces the eslint@8.57.1 snapshot change (@eslint-community/eslint-utils: 4.9.1(eslint@9.37.0)) — this happens consistently on every fresh rush update run from origin/main, so it appears to be a pnpm resolution issue rather than something introduced by our PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs triage

Development

Successfully merging this pull request may close these issues.

2 participants