Open
Conversation
- Fix unist-util-visit import (v5 changed to named export) in: - rehype-headerless-table-plugin - remark-cross-site-link-plugin - Fix React 19 JSX namespace imports in theme-rushstack-suite-nav - Remove unnecessary 'node' type from theme-rushstack-suite-nav tsconfig (resolves TextDecoder/TextEncoder conflict with DOM types) - Migrate api-documenter-docusaurus-plugin to ESLint 9 flat config format - Fix prism-react-renderer theme imports (changed to named exports) - Remove explicit webpack dependency from website packages - Add pnpm override to pin webpack to 5.98.0 for Docusaurus compatibility
- Remove `<!---->` escapes that were never needed: - The remark-cross-site-link-plugin only transforms URLs starting with '@', not link text, so '@rushstack' in link text never needed escaping - Disable api.rushstack.io in rush.json due to MDX incompatibility: - The API docs contain TypeScript type syntax in curly braces that MDX 3.x tries to parse as JavaScript expressions - Will be fixed by implementing a direct API -> MDX pipeline instead of the current API -> .md -> MDX approach
- Migrate onBrokenMarkdownLinks to markdown.hooks.onBrokenMarkdownLinks (deprecated in Docusaurus, will be removed in v4) - Fix broken anchor #heft-task-plugins → #task-plugins in blog post - Fix broken anchor in Chinese translation blog posts - Fix Chinese migration guide linking to English anchor
- heft.rushstack.io: Fix property-inheritance-directives anchor - rushjs.io: Fix 4 broken anchors linking to English instead of Chinese: - subspace-members-subspace -> 子空间成员subspace - building-changed-projects-only-unsafe -> 只构建发生变化的项目不安全 - selectors -> 选择器格式 - install-runjs-for-other-commands -> install-runjs-来执行其他命令
The deploy-fork workflow was not being used and the remark-canonical-link-plugin was causing visual regressions in Docusaurus 3.x. The plugin injected <head> tags directly into MDX content, which worked in Docusaurus 2.x (MDX1) due to automatic hoisting, but in Docusaurus 3.x (MDX2) the tags render as plain text. Changes: - Removed plugins/remark-canonical-link-plugin directory - Removed tools/deploy-fork directory - Removed deploy-fork command from rush command-line.json - Removed remark-canonical-link-plugin from rush.json and all website configs - Simplified tools/site-config to remove fork/target logic - Updated README.md to remove deploy-fork documentation - Added search-insights dependency to satisfy peer dependency
…e version using Docusaurus 2
iclanton
reviewed
Apr 16, 2026
|
|
||
| markdown: { | ||
| hooks: { | ||
| onBrokenMarkdownLinks: 'warn' |
Member
There was a problem hiding this comment.
Throwing for api-extractor.com but not here?
iclanton
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of this upgrade:
Remove the old
deploy-forkworkflow, since it's not being used and theremark-canonical-link-pluginis no longer working--> in the future, if we want to host PR builds of docsites, we should simply inject
noindexin the HTML rather than getting involved with canonical URL generation@iclanton's accessibility fixes were removed because the patches don't easily translate to the latest Docusaurus
--> we may need to reapply these fixes if they are still present in Docusaurus 3
the
api.rushstack.ioproject is temporarily removed fromrush.json; I want to rethink the way this project's inputs are generated rather than merely patching the current approach to support the latest MDX