Disable decrease counter button when value is 0 #812
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an accessibility issue where the "Decrease counter" button remained active and appeared usable when the counter value was already at 0.
Why
When the counter value is 0, the 'Decrease counter' button was still active and appeared usable even though the counter cannot go below 0. Users may be confused when they try to decrease the counter at 0 and nothing happens. This creates a misleading experience and reduces clarity of how the component is intended to work.
What
Added
disabledandaccessibilityStateprops to the decrease button that dynamically disable it when the counter value equals 0:Changes:
NewArch/src/examples/ButtonExamplePage.tsx: Addeddisabled={title === 0}andaccessibilityState={{disabled: title === 0}}to the decrease buttonScreenshots
Before: Decrease button appears active even when counter is 0
After: Decrease button is properly disabled (grayed out) when counter is 0
disable.mp4
Testing
Microsoft Reviewers: Open in CodeFlow